Skip to content

chore: upgrade @types/node to 16.x#23429

Merged
mxschmitt merged 6 commits intomicrosoft:mainfrom
kristojorg:upgrade-node-typedefs
Jun 2, 2023
Merged

chore: upgrade @types/node to 16.x#23429
mxschmitt merged 6 commits intomicrosoft:mainfrom
kristojorg:upgrade-node-typedefs

Conversation

@kristojorg
Copy link
Copy Markdown
Contributor

This PR updates @types/node to 16.x in order to get #23254 working

@kristojorg
Copy link
Copy Markdown
Contributor Author

This created a series of TS errors that I'm not entirely sure how you want to handle. If you want to commit to this branch, feel free

@yury-s
Copy link
Copy Markdown
Member

yury-s commented Jun 1, 2023

This created a series of TS errors that I'm not entirely sure how you want to handle. If you want to commit to this branch, feel free

Yeah, these errors need to be fixed to make lint run without errors. Also last time I tried to bump node type dependency version there was a bunch of failures caused by clearTimeout not expecting undefined (which was apparently fixed later).

@mxschmitt mxschmitt changed the title Upgrade node typedefs chore: upgrade @types/node to 16x and set new min Node.js version Jun 2, 2023
@mxschmitt mxschmitt changed the title chore: upgrade @types/node to 16x and set new min Node.js version chore: upgrade @types/node to 16.x Jun 2, 2023
@kristojorg
Copy link
Copy Markdown
Contributor Author

Yeah, these errors need to be fixed to make lint run without errors.

Any way you can push fixes to this branch, or tell me what route you want to take to resolve the errors and I can give it a shot?

@mxschmitt
Copy link
Copy Markdown
Contributor

I pushed to your branch to make it pass and just ended up ignoring the new undefined values, since they can only be undefined if we bind on a socket, what we won't do. See DefinitelyTyped/DefinitelyTyped#55965.

@kristojorg
Copy link
Copy Markdown
Contributor Author

Thanks @mxschmitt !

@mxschmitt mxschmitt merged commit a4a363f into microsoft:main Jun 2, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2023

"tests 1" report.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2023

"tests 1" report.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2023

"tests 2" report.

@kristojorg kristojorg deleted the upgrade-node-typedefs branch June 5, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants