chore: upgrade @types/node to 16.x#23429
Conversation
|
This created a series of TS errors that I'm not entirely sure how you want to handle. If you want to commit to this branch, feel free |
Yeah, these errors need to be fixed to make lint run without errors. Also last time I tried to bump node type dependency version there was a bunch of failures caused by |
Any way you can push fixes to this branch, or tell me what route you want to take to resolve the errors and I can give it a shot? |
|
I pushed to your branch to make it pass and just ended up ignoring the new undefined values, since they can only be undefined if we bind on a socket, what we won't do. See DefinitelyTyped/DefinitelyTyped#55965. |
|
Thanks @mxschmitt ! |
|
"tests 1" report. |
|
"tests 1" report. |
|
"tests 2" report. |
This PR updates
@types/nodeto 16.x in order to get #23254 working