Add array type support for EventPipe to TraceEvent#1176
Merged
brianrob merged 13 commits intomicrosoft:masterfrom May 27, 2020
Merged
Add array type support for EventPipe to TraceEvent#1176brianrob merged 13 commits intomicrosoft:masterfrom
brianrob merged 13 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
@noahfalk I apparently don't have the permissions to add you as reviewer |
noahfalk
approved these changes
May 21, 2020
Member
noahfalk
left a comment
There was a problem hiding this comment.
Looked good to me - mostly naming and factoring suggestions inline
Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
brianrob
reviewed
May 21, 2020
brianrob
reviewed
May 21, 2020
Contributor
Author
|
Theres one remaining failure that is only showing up in CI, I believe I know what the issue is and I'm working on it. @noahfalk you probably want to at least glance again, the changes are big enough I don't consider them just updates |
Contributor
Author
|
Ok, nevermind. It looks like this is a pre-existing failing test |
noahfalk
approved these changes
May 24, 2020
Member
noahfalk
left a comment
There was a problem hiding this comment.
Couple more small things, overall lgtm
Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
Member
Contributor
Author
|
I'm done with my changes and ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to dotnet/runtime#36242. This PR adds support for array type parsing to EventPipeEventSource.