This repository was archived by the owner on Nov 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Refine create item page (Add create data template) #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debuggy
reviewed
Dec 24, 2020
| }; | ||
|
|
||
| return ( | ||
| <Stack horizontalAlign='center' verticalAlign='space-around' gap='50px'> |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better use l2, l1, m, s1, s2 instead of pure px
webportal/src/app/create_item/components/create_data/basic_information.jsx
Outdated
Show resolved
Hide resolved
webportal/src/app/create_item/components/create_data/basic_information.jsx
Outdated
Show resolved
Hide resolved
webportal/src/app/create_item/components/create_data/basic_information.jsx
Outdated
Show resolved
Hide resolved
webportal/src/app/create_item/components/create_data/basic_information.jsx
Outdated
Show resolved
Hide resolved
webportal/src/app/create_item/components/create_data/basic_information.jsx
Outdated
Show resolved
Hide resolved
| box-shadow: rgba(0, 0, 0, 0.06) 0px 2px 4px, rgba(0, 0, 0, 0.05) 0px 0.5px 1px; | ||
| `; | ||
|
|
||
| const itemDescription = { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the UI does not show this section belongs to description clearly, I prefer to hide all those fields before it is more clear
debuggy
approved these changes
Dec 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.