This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Add searchbox in side bar #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwordFaith
reviewed
Dec 10, 2020
| const SideBar = props => { | ||
| const { type } = props; | ||
| const SideBar = () => { | ||
| const [type, setType] = useState(null); |
Contributor
There was a problem hiding this comment.
Is here change type propagation from props to redux ?
Contributor
Author
There was a problem hiding this comment.
change props to state by using react hook
SwordFaith
approved these changes
Dec 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation:
/?type=<type>&keyword=<keyword>?type=<type>&keyword=<keyword>Demo:
Test Cases:
#160
Known Issues:
search keyword is case sensitive because [Op.substring] is case sensitiveLeft work