This repository was archived by the owner on Jul 28, 2021. It is now read-only.
Remove the v1 gcs #390
Merged
Remove the v1 gcs #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOW is only supported RS5+ which already had LCOW v2. We no longer need to keep the v1 gcs impl. Signed-off-by: Justin Terry (VM) <juterry@microsoft.com> Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Closed
dcantah
reviewed
Feb 3, 2021
|
|
||
| // These are PvInvalid because they will be called previous to any protocol | ||
| // negotiation so they respond only when the protocols are not known. | ||
| if b.EnableV4 { |
Contributor
There was a problem hiding this comment.
Is there ever a time where we wouldn't use v4 going forward now?
Author
There was a problem hiding this comment.
I suppose not, but I think I'll clean that up in a separate PR just to avoid any accidental bugs here.
Contributor
|
A sea of red 😄 |
dcantah
approved these changes
Feb 3, 2021
anmaxvl
approved these changes
Feb 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LCOW is only supported on RS5+ which already had LCOW v2. Remove unused V1 code.
Signed-off-by: Justin Terry (VM) juterry@microsoft.com