Is this change as simple as adding the the following code snippet to createLinux function in this file? Or, is there another limitation/option in HCS to be considered?

if spec.Windows.Resources != nil {
	if spec.Windows.Resources.CPU != nil {
		if spec.Windows.Resources.CPU.Count != nil {
			// This check is being done here rather than in adaptContainerSettings
			// because we don't want to update the HostConfig in case this container
			// is moved to a host with more CPUs than this one.
			cpuCount := *spec.Windows.Resources.CPU.Count
			hostCPUCount := uint64(sysinfo.NumCPU())
			if cpuCount > hostCPUCount {
				c.logger.Warnf("Changing requested CPUCount of %d to current number of processors, %d", cpuCount, hostCPUCount)
				cpuCount = hostCPUCount
			}
			configuration.ProcessorCount = uint32(cpuCount)
		}
		if spec.Windows.Resources.CPU.Shares != nil {
			configuration.ProcessorWeight = uint64(*spec.Windows.Resources.CPU.Shares)
		}
		if spec.Windows.Resources.CPU.Maximum != nil {
			configuration.ProcessorMaximum = int64(*spec.Windows.Resources.CPU.Maximum)
		}
	}
	if spec.Windows.Resources.Memory != nil {
		if spec.Windows.Resources.Memory.Limit != nil {
			configuration.MemoryMaximumInMB = int64(*spec.Windows.Resources.Memory.Limit) / 1024 / 1024
		}
	}
	if spec.Windows.Resources.Storage != nil {
		if spec.Windows.Resources.Storage.Bps != nil {
			configuration.StorageBandwidthMaximum = *spec.Windows.Resources.Storage.Bps
		}
		if spec.Windows.Resources.Storage.Iops != nil {
			configuration.StorageIOPSMaximum = *spec.Windows.Resources.Storage.Iops
		}
	}
}

docker doesn't use memory or CPU options #145

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions