[torchlib] Unregister aten::max.other#2377
Merged
titaiwangms merged 3 commits intomicrosoft:mainfrom Jun 13, 2025
Merged
Conversation
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2377 +/- ##
==========================================
- Coverage 70.12% 70.12% -0.01%
==========================================
Files 197 197
Lines 25003 25003
Branches 2670 2670
==========================================
- Hits 17534 17533 -1
- Misses 6537 6538 +1
Partials 932 932 ☔ View full report in Codecov by Sentry. |
justinchuby
reviewed
Jun 13, 2025
justinchuby
approved these changes
Jun 13, 2025
justinchuby
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue revealed by #2371, which aten.max.other is lack of matching overload. It's caused by missing type promotion. The reason is that aten::max.other (binary max) is an alias of aten::maimum.default. Thus, iwhen type promotion pass dispatches torch.max through
__torch__dispatch__, it does not find aten::max.other (However, I am not sure howmake_fxdispatches torch.max to aten::max.other).The existence of aten::max.other looks like a legacy code: pytorch/pytorch#42579.