Skip to content

Conversation

@shubhambhokare1
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.61%. Comparing base (fe9f29a) to head (774323b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1538   +/-   ##
=======================================
  Coverage   77.61%   77.61%           
=======================================
  Files         212      212           
  Lines       23023    23023           
  Branches     3951     3951           
=======================================
  Hits        17869    17869           
  Misses       4397     4397           
  Partials      757      757           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented May 14, 2024

Test Results

     29 files  ±0       29 suites  ±0   3h 7m 7s ⏱️ - 8m 58s
  8 308 tests ±0    6 818 ✅ +4    1 489 💤 ± 0  1 ❌  -  2 
578 952 runs  ±0  118 161 ✅ +2  460 790 💤 +56  1 ❌  - 56 

For more details on these failures, see this check.

Results for commit 774323b. ± Comparison against base commit fe9f29a.

♻️ This comment has been updated with latest results.

@justinchuby
Copy link
Collaborator

Thanks for creating the fix! Minor comments

Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@justinchuby justinchuby merged commit ebee154 into main May 14, 2024
@justinchuby justinchuby deleted the sbhokare/fix-mac-tests branch May 14, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

[torchlib] native_layer_norm_float32 is failing on MacOS CI with significant absolute difference

3 participants