Improve handling of missing vocab_file attribute in HFTokenizerConverter#677
Merged
wenbingl merged 2 commits intomicrosoft:mainfrom Mar 26, 2024
Merged
Conversation
…erter This commit updates `HFTokenizerConverter` to handle cases where the `hf_tokenizer` object might not have a `vocab_file` attribute. Changes: * Uses `getattr` to retrieve the `vocab_file` attribute for flexibility * Stores the retrieved value in a separate variable `vocab_file` for clarity * Checks if `vocab_file` is `None` before checking its existence This ensures the converter works correctly even with tokenizers that don't define a `vocab_file` attribute.
Contributor
Author
|
I'm not sure but it looks like |
Collaborator
|
/azp run onnxruntime-extensions.CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates
HFTokenizerConverterto handle cases where thehf_tokenizerobject might not have avocab_fileattribute.Changes:
getattrto retrieve thevocab_fileattribute for flexibilityvocab_filefor clarityvocab_fileisNonebefore checking its existenceThis ensures the converter works correctly even with tokenizers that don't define a
vocab_fileattribute.