Skip to content

Fix slice conformance failures #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ryanlai2 merged 1 commit into from
Feb 4, 2020
Merged

Fix slice conformance failures #2908

ryanlai2 merged 1 commit into from
Feb 4, 2020

Conversation

@jeffbloo
Copy link
Contributor

@jeffbloo jeffbloo commented Jan 25, 2020

This adds a fix for handling negative axes which was lost in merges

@jeffbloo jeffbloo requested a review from fdwr January 25, 2020 00:51
@jeffbloo jeffbloo requested a review from a team as a code owner January 25, 2020 00:51
@ryanlai2 ryanlai2 merged commit e83c39f into windowsai Feb 4, 2020
@ryanlai2 ryanlai2 deleted the jeffbloo/FixConformanceFailures branch February 4, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdwr fdwr fdwr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeffbloo @fdwr @ryanlai2