Skip to content

allow build flag --use_external_dawn #22552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fs-eire merged 2 commits into from
Oct 24, 2024
Merged

allow build flag --use_external_dawn #22552

fs-eire merged 2 commits into from
Oct 24, 2024

Conversation

@fs-eire
Copy link
Contributor

@fs-eire fs-eire commented Oct 23, 2024

Description

introduce this build flag --use_external_dawn to allow specifying Dawn as an external dependency. When it is specified, dawn::native is excluded from build of onnxruntime, and passing in dawn proc table is required.

I didn't find a good way to run the test. Currently I need to build with the following flags:

C:\code\onnxruntime>build --use_webgpu --use_external_dawn --skip_tests --target onnxruntime_webgpu_external_dawn_test

And run the test using:

# run test that passing dawn proc table. expect session to initialize successfully
C:\code\onnxruntime\build\Windows\Debug\Debug>onnxruntime_webgpu_external_dawn_test.exe

# run test that does not pass proc table. expect exception to throw.
C:\code\onnxruntime\build\Windows\Debug\Debug>onnxruntime_webgpu_external_dawn_test.exe --no_proc_table

snnn
snnn reviewed Oct 23, 2024
View reviewed changes
@fs-eire fs-eire requested a review from a team October 24, 2024 06:09
@fs-eire fs-eire merged commit a00f5b8 into fs-eire/webgpu-ep Oct 24, 2024
@fs-eire fs-eire deleted the fs-eire/webgpu-ep-dawn-ext branch October 24, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guschmue guschmue guschmue approved these changes

+1 more reviewer

@snnn snnn snnn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fs-eire @snnn @guschmue