Skip to content

Enable >2GB models + allow model paths to be passed for generate_artifacts API#20958

Merged
carzh merged 14 commits intomicrosoft:mainfrom
carzh:carzh/generate-artifacts-large-models
Jun 21, 2024
Merged

Enable >2GB models + allow model paths to be passed for generate_artifacts API#20958
carzh merged 14 commits intomicrosoft:mainfrom
carzh:carzh/generate-artifacts-large-models

Conversation

@carzh
Copy link
Copy Markdown
Contributor

@carzh carzh commented Jun 6, 2024

Description

Alternative design from #20942

Allow users to pass in a model path for the generate_artifacts API.

Motivation and Context

  • ONNX API calls such as the onnx checker + shape inference fail when given a model > 2GB, but work if a path to a model >2GB is passed in.

Comment thread orttraining/orttraining/python/training/artifacts.py Fixed
Comment thread orttraining/orttraining/python/training/onnxblock/model_accessor.py Fixed
Comment thread orttraining/orttraining/python/training/onnxblock/model_accessor.py Fixed
@carzh carzh requested review from baijumeswani and skottmckay June 13, 2024 06:15
@carzh carzh marked this pull request as ready for review June 13, 2024 06:15
Comment thread orttraining/orttraining/python/training/onnxblock/blocks.py Outdated
Comment thread orttraining/orttraining/python/training/onnxblock/loss/loss.py Outdated
Comment thread orttraining/orttraining/python/training/onnxblock/onnxblock.py Outdated
Comment thread orttraining/orttraining/python/training/onnxblock/onnxblock.py Outdated
Comment thread orttraining/orttraining/test/python/orttraining_test_ort_apis_onnxblock.py Outdated
Comment thread orttraining/orttraining/test/python/orttraining_test_ort_apis_onnxblock.py Outdated
Comment thread orttraining/orttraining/python/training/onnxblock/blocks.py Outdated
carzh added 2 commits June 19, 2024 18:31
…nerate_artifacts typically will throw an error if unsuccessful
baijumeswani
baijumeswani previously approved these changes Jun 19, 2024
skottmckay
skottmckay previously approved these changes Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants