Skip to content

Conversation

@liqunfu
Copy link
Contributor

@liqunfu liqunfu commented Oct 6, 2023

Description

dft is updated in opset20. implement it in ort

Motivation and Context

this is for ort 1.17.0 release

Fixes #17723

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu added this to the 1.17 milestone Oct 6, 2023
@justinchuby justinchuby changed the title implement dft(20) Implement dft(20) Oct 17, 2023
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@justinchuby
Copy link
Contributor

justinchuby commented Nov 9, 2023

I would make sure ORT behaves correctly when axis=0. Currently the output shape is not right (CPU EP).

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
Copy link
Contributor Author

liqunfu commented Nov 9, 2023

I would make sure ORT behaves correctly when axis=0. Currently the output shape is not right (CPU EP).

@justinchuby do we have test for this case. All onnx test cases are passing.

@liqunfu
Copy link
Contributor Author

liqunfu commented Nov 25, 2023

I would make sure ORT behaves correctly when axis=0. Currently the output shape is not right (CPU EP).

@justinchuby do we have test for this case. All onnx test cases are passing.

I extended test cases to axis=0 for since version being 20.

@liqunfu liqunfu closed this Nov 28, 2023
@liqunfu liqunfu reopened this Nov 28, 2023
@justinchuby justinchuby merged commit 32fcf73 into main Dec 19, 2023
@justinchuby justinchuby deleted the liqun/dft20 branch December 19, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add compute kernel for DFT(20)

4 participants