Update C++ to standard 20 for Windows #17706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
reviewed
Jun 4, 2024
edgchen1
reviewed
Jun 4, 2024
edgchen1
reviewed
Jun 4, 2024
Contributor
Author
|
AB#15150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current blocker:
1. The date project from github is dead. It does not support c++20
2. C100 "Internal compiler error" from VC++ arm64 compiler, Windows ARM64 QNN CI Pipeline
3. Not enough disk space on Windows CI pipeline
4. Chaning is_pod to is_trivial
Mix use of
stringandwstringis not tolerated in C++20. Tracking with Using wostringstream only on Windows #21938Motivation and Context
AB#15150