-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Closed
Labels
platform:mobileissues related to ONNX Runtime mobile; typically submitted using templateissues related to ONNX Runtime mobile; typically submitted using template
Description
Describe the issue
Hey,
I've seen we're using this MLMultiArray.dataPointer method here https://github.com/microsoft/onnxruntime/blob/main/onnxruntime/core/providers/coreml/model/model.mm#L327 to access the underlying memory before moving that to a C lifetime-managed location.
I noticed this method appears to be deprecated on Apple docs. I am merely speculating, but maybe is it because they support non-contiguously stored MLMultiArrays..?
My question is should we do something about this, like using some of the other non-deprecated element access methods (although it may decrease performance compared to memcpy), or are we sure this won't ever cause issues going forward?
To reproduce
Urgency
No response
Platform
iOS
OS Version
/
ONNX Runtime Installation
Released Package
Compiler Version (if 'Built from Source')
No response
Package Name (if 'Released Package')
None
ONNX Runtime Version or Commit ID
1.16.0
ONNX Runtime API
C++/C
Architecture
ARM64
Execution Provider
CoreML
Execution Provider Library Version
No response
Metadata
Metadata
Assignees
Labels
platform:mobileissues related to ONNX Runtime mobile; typically submitted using templateissues related to ONNX Runtime mobile; typically submitted using template