Merged
Conversation
Retry logic
To help debug an irreproducable/random mismatch error if it occurs in the future.
This reverts commit 25301e6.
added an error code to determine if the query has timed out. Statement will attempt to catch a timeout error, and throw java.sql.TimeoutException if it does.
more readable, and shorter
changed test to expect the new SQLTimeoutException
Codecov Report
@@ Coverage Diff @@
## dev #641 +/- ##
============================================
+ Coverage 46.47% 46.47% +<.01%
+ Complexity 2228 2227 -1
============================================
Files 109 109
Lines 25439 25449 +10
Branches 4190 4193 +3
============================================
+ Hits 11822 11828 +6
Misses 11574 11574
- Partials 2043 2047 +4
Continue to review full report at Codecov.
|
less catching, more throwing.
Have the exception handle setting its own properties instead of setting it in IOBuffer where it's out of place.
changed tests to expect SQLException instead of SQLServerException.
…ql-jdbc into SQLTimeoutExcepetion
reverted typed changes due to possibility of breaking customer applications.
Handles a case where strings would be translated and the error would not be thrown
cheenamalhotra
approved these changes
Mar 8, 2018
fixed an error where the script replaced SQLServerException would produce "throw SQLException, SQLException"
fixed comments that were incorrectly modified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.