Added needsPrepare Check and removed error code 99586 check#629
Merged
cheenamalhotra merged 4 commits intomicrosoft:devfrom Feb 16, 2018
Merged
Added needsPrepare Check and removed error code 99586 check#629cheenamalhotra merged 4 commits intomicrosoft:devfrom
cheenamalhotra merged 4 commits intomicrosoft:devfrom
Conversation
…pare to class level declaration to avoid multi-threading issues.
TobiasSQL
suggested changes
Feb 15, 2018
| /** True if this execute has been called for this statement at least once */ | ||
| private boolean isExecutedAtLeastOnce = false; | ||
|
|
||
| private boolean needsPrepare = false; |
Contributor
There was a problem hiding this comment.
Why do we need needsPrepare as a instance field? Should always be local variable.
TobiasSQL
suggested changes
Feb 15, 2018
| } | ||
|
|
||
| String dbName = connection.getSCatalog(); | ||
| boolean needsPrepare = false; |
Contributor
There was a problem hiding this comment.
Let's make the default true to be safe (better prepare than not). Should not matter but just to be a bit defensive...
Contributor
There was a problem hiding this comment.
Otherwise things look good :-)
Member
Author
There was a problem hiding this comment.
Modified to true.
Codecov Report
@@ Coverage Diff @@
## dev #629 +/- ##
============================================
+ Coverage 46.52% 46.57% +0.05%
- Complexity 2223 2228 +5
============================================
Files 109 109
Lines 25408 25409 +1
Branches 4186 4187 +1
============================================
+ Hits 11821 11835 +14
+ Misses 11554 11544 -10
+ Partials 2033 2030 -3
Continue to review full report at Codecov.
|
TobiasSQL
approved these changes
Feb 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.