Removal of deprecated APIs and update travic script with jdk 9#577
Removal of deprecated APIs and update travic script with jdk 9#577AfsanehR-zz merged 5 commits intomicrosoft:JDBC4.3from
Conversation
Codecov Report
@@ Coverage Diff @@
## JDBC4.3 #577 +/- ##
=============================================
- Coverage 46.52% 46.46% -0.07%
+ Complexity 2217 2213 -4
=============================================
Files 108 108
Lines 25363 25373 +10
Branches 4177 4177
=============================================
- Hits 11800 11789 -11
- Misses 11533 11560 +27
+ Partials 2030 2024 -6
Continue to review full report at Codecov.
|
xiangyushawn
left a comment
There was a problem hiding this comment.
The PR looks good to me. just wondering why we use Integer.valueOf() sometimes and sometimes we use Integer.parseInt()?
|
@v-xiangs good point. The difference between those two is that Integer.parseInt() return primitive int and valueOf returns java.lang.Integer. I mostly used Integer.parseInt(String) except for the line that we need to convert Int to string. for example here: using Integer.valueOf() allows us to call toString() method on the Object. |
No description provided.