Skip to content

Java 9 Updates for JDBC4.3 branch only#566

Merged
AfsanehR-zz merged 10 commits intomicrosoft:JDBC4.3from
AfsanehR-zz:Java9
Nov 29, 2017
Merged

Java 9 Updates for JDBC4.3 branch only#566
AfsanehR-zz merged 10 commits intomicrosoft:JDBC4.3from
AfsanehR-zz:Java9

Conversation

@AfsanehR-zz
Copy link
Copy Markdown
Contributor

@AfsanehR-zz AfsanehR-zz commented Nov 27, 2017

This pull request includes:

  1. Removal of dependency to javax.xml.bind.DatatypeConverter by using the java.util.Base64 introduced in Java 8.
  2. Removing 4.1 jar build script. This branch now supports only for JDBC 4.2 and JDBC 4.3 compatible jars.
  3. Adding unsupported feature exception for new APIs including Sharding.
  4. Modifying travis-ci scripts to build with jdk9.
  5. Commenting the builds for Appveyor as jdk9 is not supported yet with Appveyor.
  6. Fixing java.lang.NoSuchMethodError: java.nio.ByteBuffer.limit(I)Ljava/nio/ByteBuffer introduced in Java 9.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 27, 2017 •
edited
Loading

Codecov Report

Merging #566 into JDBC4.3 will decrease coverage by 46.55%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             JDBC4.3    #566       +/-   ##
=============================================
- Coverage      46.55%      0%   -46.56%     
=============================================
  Files            108     108               
  Lines          25321   25363       +42     
  Branches        4175    4177        +2     
=============================================
- Hits           11788       0    -11788     
- Misses         11503   25363    +13860     
+ Partials        2030       0     -2030
Flag Coverage Δ Complexity Δ
#JDBC41 0% <0%> (-46.33%) 0 <0> (-2203)
#JDBC42 0% <0%> (-46.44%) 0 <0> (-2209)
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 0% <ø> (-32.54%) 0 <0> (-240)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 0% <0%> (-45.76%) 0 <0> (-277)
...oft/sqlserver/jdbc/SQLServerSymmetricKeyCache.java 0% <0%> (-57.54%) 0 <0> (-5)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 0% <0%> (-53.97%) 0 <0> (ø)
.../com/microsoft/sqlserver/jdbc/SQLServerJdbc43.java 0% <0%> (ø) 0 <0> (?)
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 0% <0%> (-45.99%) 0 <0> (-66)
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 0% <0%> (-35.6%) 0 <0> (-55)
...erverColumnEncryptionCertificateStoreProvider.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ver/jdbc/SQLServerAeadAes256CbcHmac256Factory.java 0% <0%> (-70%) 0 <0> (-4)
.../com/microsoft/sqlserver/jdbc/SQLServerJdbc42.java 0% <0%> (-25%) 0 <0> (ø)
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f9fec6...778d3ee. Read the comment docs.

@AfsanehR-zz AfsanehR-zz merged commit 8c7f465 into microsoft:JDBC4.3 Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

+1 more reviewer

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cheenamalhotra cheenamalhotra

@peterbae peterbae

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AfsanehR-zz @codecov-io @cheenamalhotra @peterbae @lilgreenbird