Skip to content

Fix for EnablePrepareOnFirst...Call with statement pooling turned off#513

Merged
xiangyushawn merged 1 commit intodevfrom
metadataCaching
Nov 30, 2017
Merged

Fix for EnablePrepareOnFirst...Call with statement pooling turned off#513
xiangyushawn merged 1 commit intodevfrom
metadataCaching

Conversation

@TobiasSQL
Copy link
Copy Markdown
Contributor

@TobiasSQL TobiasSQL commented Sep 27, 2017

This fix needs to be ported to dev and master. Current behavior in both branches will cause multiple PreparedStatement instances with the same SQL text not to honor EnablePrepareOnFirstPreparedStatementCall. This will in turn hurt performance slightly by unnecessarily preparing statement handles on the server.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 27, 2017 •
edited
Loading

Codecov Report

Merging #513 into dev will decrease coverage by 0.27%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #513      +/-   ##
============================================
- Coverage     46.51%   46.24%   -0.28%     
- Complexity     2218     2666     +448     
============================================
  Files           108      108              
  Lines         25312    34935    +9623     
  Branches       4181     6819    +2638     
============================================
+ Hits          11775    16154    +4379     
- Misses        11501    16119    +4618     
- Partials       2036     2662     +626
Flag Coverage Δ Complexity Δ
#JDBC41 46.08% <66.66%> (-0.31%) 2655 <0> (+446)
#JDBC42 46.1% <66.66%> (-0.15%) 2659 <0> (+453)
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 49.42% <66.66%> (-2.15%) 230 <0> (+65)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 52.6% <0%> (-9.42%) 63% <0%> (ø)
src/main/java/com/microsoft/sqlserver/jdbc/AE.java 65.13% <0%> (-8.83%) 0% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 55.92% <0%> (-7.2%) 0% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 72.06% <0%> (-5.73%) 10% <0%> (+5%)
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 24.19% <0%> (-5%) 77% <0%> (-13%)
...om/microsoft/sqlserver/jdbc/SQLServerMetaData.java 20% <0%> (-4%) 0% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 55.28% <0%> (-3.9%) 93% <0%> (+5%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 39.92% <0%> (-3.33%) 103% <0%> (-1%)
...osoft/sqlserver/jdbc/SQLServerSecurityUtility.java 47.88% <0%> (-2.86%) 10% <0%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d0388...89c92b7. Read the comment docs.

@TobiasSQL TobiasSQL self-assigned this Sep 27, 2017
@TobiasSQL TobiasSQL requested a review from ajlam September 27, 2017 15:24
@TobiasSQL TobiasSQL removed their assignment Sep 27, 2017
@TobiasSQL
Copy link
Copy Markdown
Contributor Author

TobiasSQL commented Nov 28, 2017

Any comments? Ready to merge?

@xiangyushawn
Copy link
Copy Markdown
Contributor

xiangyushawn commented Nov 30, 2017

@TobiasSQL Hello, we just finished code review and ready to merge the PR. Thank you.

@xiangyushawn xiangyushawn merged commit 01e8013 into dev Nov 30, 2017
@AfsanehR-zz AfsanehR-zz deleted the metadataCaching branch January 23, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajlam ajlam Awaiting requested review from ajlam

@AfsanehR-zz AfsanehR-zz Awaiting requested review from AfsanehR-zz

1 more reviewer

@xiangyushawn xiangyushawn xiangyushawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TobiasSQL @codecov-io @xiangyushawn @lilgreenbird