Merged
Conversation
Replace bare literals with magic constants. For example: `cal.set(1, 1, 577738, 0, 0, 0);` becomes `cal.set(1, Calendar.FEBRUARY, 577738, 0, 0, 0);`
Codecov Report
@@ Coverage Diff @@
## dev #502 +/- ##
============================================
- Coverage 46.64% 46.62% -0.02%
+ Complexity 2218 2217 -1
============================================
Files 108 108
Lines 25279 25279
Branches 4167 4167
============================================
- Hits 11791 11787 -4
- Misses 11463 11464 +1
- Partials 2025 2028 +3
Continue to review full report at Codecov.
|
Contributor
|
@JamieMagee : Good. It will make code more readable. |
| catch (SQLException e) { | ||
| SQLServerException.makeFromDriverError(con, stmtParent, e.toString(), null, false); | ||
| return 0; | ||
| return ParameterMetaData.parameterModeUnknown; |
Member
There was a problem hiding this comment.
@JamieMagee You could avoid using 'ParameterMetaData' interface reference explicitly here since SQLServerParameterMetadata already implements it. The constants are available directly.
cheenamalhotra
approved these changes
Oct 12, 2017
AfsanehR-zz
approved these changes
Oct 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bare literals with magic constants. For example:
cal.set(1, 1, 577738, 0, 0, 0);becomes
cal.set(1, Calendar.FEBRUARY, 577738, 0, 0, 0);