removing javax.xml.bind package dependency #485
Merged
AfsanehR-zz merged 6 commits intomicrosoft:devfrom Sep 14, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #485 +/- ##
============================================
- Coverage 46.37% 46.24% -0.13%
+ Complexity 2212 2203 -9
============================================
Files 108 108
Lines 25231 25230 -1
Branches 4173 4173
============================================
- Hits 11700 11667 -33
- Misses 11524 11555 +31
- Partials 2007 2008 +1
Continue to review full report at Codecov.
|
| isNull = (null == currentObject); | ||
| if (currentObject instanceof String) | ||
| dataLength = isNull ? 0 : (toByteArray(currentObject.toString())).length; | ||
| dataLength = isNull ? 0 : (ParameterUtils.HexToBin(currentObject.toString())).length; |
Contributor
There was a problem hiding this comment.
for this ParameterUtils class, are we adding new dependency to the driver?
Contributor
Author
There was a problem hiding this comment.
No, this is an existing class.
Contributor
There was a problem hiding this comment.
oh never mind, it's existing code in the driver
xiangyushawn
approved these changes
Sep 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.