Skip to content

Cleanup travis appveyor#473

Merged
AfsanehR-zz merged 3 commits intomicrosoft:devfrom
sehrope:cleanup-travis-appveyor
Sep 18, 2017
Merged

Cleanup travis appveyor#473
AfsanehR-zz merged 3 commits intomicrosoft:devfrom
sehrope:cleanup-travis-appveyor

Conversation

@sehrope
Copy link
Copy Markdown
Contributor

@sehrope sehrope commented Sep 1, 2017

Minor cleanup of missing newlines and removal of commented out block from .travis.yml and appveyor.yml.

@sehrope
Copy link
Copy Markdown
Contributor Author

sehrope commented Sep 1, 2017

Odd that Travis failed for one test as nothing has actually changed in the driver or tests.

Issue is likely a race condition in one of the tests:

testQueryTimeout()  Time elapsed: 6.902 sec  <<< FAILURE!
org.opentest4j.AssertionFailedError: 2nd execution didn't take long enough. ==> expected: <6500> but was: <4354>
	at com.microsoft.sqlserver.jdbc.unit.statement.StatementTest$TCAttentionHandling.testQueryTimeout(StatementTest.java:208)

@AfsanehR-zz
Copy link
Copy Markdown
Contributor

AfsanehR-zz commented Sep 1, 2017

Thanks @sehrope! Will mark this failure. I kicked of the test again to pass.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 1, 2017

Codecov Report

Merging #473 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #473      +/-   ##
============================================
- Coverage     46.26%   46.25%   -0.01%     
+ Complexity     2201     2198       -3     
============================================
  Files           108      108              
  Lines         25227    25227              
  Branches       4172     4172              
============================================
- Hits          11672    11670       -2     
+ Misses        11538    11530       -8     
- Partials       2017     2027      +10
Flag Coverage Δ Complexity Δ
#JDBC41 46.06% <ø> (ø) 2187 <ø> (-5) ⬇️
#JDBC42 46.15% <ø> (+0.03%) 2196 <ø> (-1) ⬇️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-2.25%) 16% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 43.82% <0%> (-1.13%) 104% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.01% <0%> (-0.65%) 63% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.81% <0%> (-0.41%) 242% <0%> (-2%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.2% <0%> (-0.22%) 46% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.11% <0%> (-0.13%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.58% <0%> (-0.07%) 239% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.08% <0%> (+0.73%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a13577...6f0bc72. Read the comment docs.

@AfsanehR-zz AfsanehR-zz merged commit 9272e40 into microsoft:dev Sep 18, 2017
@AfsanehR-zz
Copy link
Copy Markdown
Contributor

AfsanehR-zz commented Sep 18, 2017

Thanks @sehrope for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sehrope @AfsanehR-zz @codecov-io @lilgreenbird @msftclas