Skip to content

Support for smallDateTime/Datetime in TVP#435

Merged
AfsanehR-zz merged 4 commits intomicrosoft:devfrom
AfsanehR-zz:tvpSmallDateTimeDatetime2
Aug 8, 2017
Merged

Support for smallDateTime/Datetime in TVP#435
AfsanehR-zz merged 4 commits intomicrosoft:devfrom
AfsanehR-zz:tvpSmallDateTimeDatetime2

Conversation

@AfsanehR-zz
Copy link
Copy Markdown
Contributor

@AfsanehR-zz AfsanehR-zz commented Aug 8, 2017 •
edited
Loading

recreated pr #407 for issue #408

@AfsanehR-zz
Merge branch 'JunitTesting' of https://github.com/peterbae/mssql-jdbc …
afa98f0 
…into dev
@AfsanehR-zz
Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into dev
99b32f5
@AfsanehR-zz
Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into dev
3ee92b7
@AfsanehR-zz
Add datetime/smalldatetime support for tvp
812aecc 
Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into tvpDatetimeSmallDateTime

# Conflicts:
#	src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
#	src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDataTable.java
@AfsanehR-zz AfsanehR-zz mentioned this pull request Aug 8, 2017
Closed
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 8, 2017 •
edited
Loading

Codecov Report

Merging #435 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #435      +/-   ##
============================================
- Coverage     46.28%   46.27%   -0.02%     
+ Complexity     2200     2195       -5     
============================================
  Files           108      108              
  Lines         25210    25210              
  Branches       4164     4164              
============================================
- Hits          11668    11665       -3     
- Misses        11511    11520       +9     
+ Partials       2031     2025       -6
Flag Coverage Δ Complexity Δ
#JDBC41 45.99% <ø> (-0.11%) 2182 <ø> (-8)
#JDBC42 46.18% <ø> (+0.01%) 2194 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.08% <ø> (+0.13%) 0 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerDataTable.java 57.25% <ø> (ø) 23 <0> (ø) ⬇️
...ava/com/microsoft/sqlserver/jdbc/ScrollWindow.java 65.85% <0%> (-7.32%) 16% <0%> (-1%)
...va/com/microsoft/sqlserver/jdbc/StreamColumns.java 87.83% <0%> (-1.36%) 21% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.26% <0%> (-0.45%) 104% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.49% <0%> (-0.29%) 239% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.44% <0%> (+0.12%) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.67% <0%> (+0.12%) 240% <0%> (-1%) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 77.79% <0%> (+0.16%) 5% <0%> (+1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd913d...812aecc. Read the comment docs.

@AfsanehR-zz AfsanehR-zz merged commit d4cc533 into microsoft:dev Aug 8, 2017
@AfsanehR-zz AfsanehR-zz mentioned this pull request Aug 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xiangyushawn xiangyushawn xiangyushawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AfsanehR-zz @codecov-io @xiangyushawn @lilgreenbird @msftclas @meet-bhagdev