Junit testing by peterbae · Pull Request #432 · microsoft/mssql-jdbc

peterbae · 2017-08-03T19:27:23Z

Added CallableStatementTest and PrecisionScaleTest

…emoved RandomData inside jdbc.datatypes beacuse it's redundant

msftclas · 2017-08-03T19:27:26Z

@peterbae,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

AfsanehR-zz · 2017-08-04T19:39:20Z

src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/CallableStatementTest.java

+    }
+
+    private static void dropTables() throws SQLException {
+        stmt.executeUpdate("if object_id('" + table1 + "','U') is not null" + " drop table " + table1);


let's use Utils.dropTable

AfsanehR-zz · 2017-08-08T15:59:01Z

src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/CallableStatementTest.java

+
+import java.math.BigDecimal;
+import java.sql.Date;
+import java.sql.DriverManager;


please delete the unused imports

AfsanehR-zz · 2017-08-08T16:09:55Z

src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/CallableStatementTest.java

@@ -0,0 +1,2645 @@
+package com.microsoft.sqlserver.jdbc.AlwaysEncrypted;


missing header

AfsanehR-zz · 2017-08-08T16:10:43Z

src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/PrecisionScaleTest.java

+    }
+
+    @Test
+    public void testNumericPrecision8Scale2_Null() throws Exception {


remove _ in the test name

AfsanehR-zz · 2017-08-08T16:13:33Z

src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/PrecisionScaleTest.java

+                .format(new Date(1450812362177L - offsetFromGMT - offsetFromGMT + offset));
+    }
+
+    @Test


Great work. One last comment is to add javadocs for the test methods and a general description at the beginning of the file explaining what each class file is containing and testing.

codecov-io · 2017-08-08T18:22:59Z

Codecov Report

Merging #432 into dev will increase coverage by 0.27%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #432      +/-   ##
============================================
+ Coverage     45.92%   46.19%   +0.27%     
+ Complexity     2198     2194       -4     
============================================
  Files           108      108              
  Lines         25210    25210              
  Branches       4164     4164              
============================================
+ Hits          11577    11646      +69     
+ Misses        11711    11548     -163     
- Partials       1922     2016      +94

Flag	Coverage Δ	Complexity Δ
#JDBC41	`46.04% <ø> (+0.36%)`	`2185 <ø> (ø)`	⬇️
#JDBC42	`46.03% <ø> (+0.22%)`	`2183 <ø> (-9)`	⬇️

Impacted Files	Coverage Δ	Complexity Δ
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java	`51.11% <0%> (-5.19%)`	`11% <0%> (-5%)`
...ava/com/microsoft/sqlserver/jdbc/ScrollWindow.java	`73.17% <0%> (-2.44%)`	`17% <0%> (-2%)`
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java	`53.52% <0%> (-1.73%)`	`0% <0%> (ø)`
...m/microsoft/sqlserver/jdbc/SQLServerException.java	`75.6% <0%> (-1.63%)`	`28% <0%> (-1%)`
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java	`68.46% <0%> (-0.91%)`	`0% <0%> (ø)`
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java	`59.17% <0%> (-0.87%)`	`88% <0%> (-3%)`
...oft/sqlserver/jdbc/SQLServerResultSetMetaData.java	`40.97% <0%> (-0.7%)`	`23% <0%> (-1%)`
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java	`52.61% <0%> (-0.39%)`	`239% <0%> (-4%)`
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java	`32.86% <0%> (-0.29%)`	`242% <0%> (-9%)`
.../microsoft/sqlserver/jdbc/SQLServerConnection.java	`45.71% <0%> (-0.24%)`	`273% <0%> (-15%)`
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7741ee9...3f0baf0. Read the comment docs.

AfsanehR-zz · 2017-08-08T19:56:43Z

Thank you @peterbae for fixing other test classes!

peterbae added 3 commits August 2, 2017 14:26

Junit changes - added CallableStatementTest and PrecisionScaleTest. R…

c5f00c5

…emoved RandomData inside jdbc.datatypes beacuse it's redundant

Fix timezone issues with testing

cf9ae2e

Fix more issues with timezone

b0aa7fa

peterbae requested a review from AfsanehR-zz August 3, 2017 19:27

msftclas added the cla-required label Aug 3, 2017

ajlam added PR Under Review and removed cla-required labels Aug 3, 2017

AfsanehR-zz reviewed Aug 8, 2017

View reviewed changes

Add javadoc/fix issues

ddde692

Got rid of all the underscores in method names

3f0baf0

AfsanehR-zz approved these changes Aug 8, 2017

View reviewed changes

peterbae merged commit fcd913d into microsoft:dev Aug 8, 2017

meet-bhagdev removed the PR Under Review label Aug 8, 2017

		@@ -0,0 +1,2645 @@
		package com.microsoft.sqlserver.jdbc.AlwaysEncrypted;

Conversation

peterbae commented Aug 3, 2017

Uh oh!

msftclas commented Aug 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Aug 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AfsanehR-zz commented Aug 8, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov-io commented Aug 8, 2017 •

edited

Loading