use matrix to test against both SQL Server 2016 and 2008#428
use matrix to test against both SQL Server 2016 and 2008#428xiangyushawn merged 6 commits intomicrosoft:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #428 +/- ##
===========================================
- Coverage 46.55% 46.45% -0.1%
+ Complexity 2214 2210 -4
===========================================
Files 108 108
Lines 25321 25321
Branches 4175 4175
===========================================
- Hits 11789 11764 -25
- Misses 11506 11538 +32
+ Partials 2026 2019 -7
Continue to review full report at Codecov.
|
appveyor.yml
Outdated
| - mssql_jdbc_test_connection_properties: jdbc:sqlserver://localhost:1433;instanceName=SQL2016;databaseName=master;username=sa;password=Password12!; | ||
|
|
||
| services: | ||
| - mssql2008r2sp2 |
There was a problem hiding this comment.
Will it work?
I guess you should add services also in matrix.
matrix:
- SQL: mssql2008r2sp2
mssql_jdbc_test_connection_properties: jdbc:sqlserver://localhost:1433;instanceName=SQL2008R2SP2;databaseName=master;username=sa;password=Password12!;
- SQL: mssql2016
mssql_jdbc_test_connection_properties: jdbc:sqlserver://localhost:1433;instanceName=SQL2016;databaseName=master;username=sa;password=Password12!;
I did not check this but definitely you want matrix of services too.
Also please note that all MS SQL servers use the same default port 1433. Therefore please start and stop them sequentially to avoid port conflicts. To allow all SQL Server instances to be started simultaneously, please run this script at init stage.
There was a problem hiding this comment.
Hello @nsidhaye Hope you are doing well! from my investigation, matrix does not support services. Before I create this PR, I tested it in my personal fork and it worked this way. Thank you for sharing the link, I definitely will try it! If it works I will update my PR. Thank you :)
There was a problem hiding this comment.
thank you @nsidhaye for sharing the link! I didn't find this link when I was doing investigation. I really love the idea to specify variables in matrix and then use CMD to start services! I updated my PR. Thank you for knowledge sharing!
…st-agaist-both-2008-and-2016
PR #543 fixes failures that are not caught by CIs on SQL Server 2008 because we do not have CI running against 2008.
Create this PR to test both 2008 and 2016 on Appveyor by using matrix. This will help us improve PR qualities.
This PR fails for now on SQL Server 2008 until we merge PR #543