Skip to content

Give option to skip certian tests base on Tag#425

Merged
xiangyushawn merged 3 commits intomicrosoft:devfrom
xiangyushawn:give-option-to-skip-long-running-tests
Aug 10, 2017
Merged

Give option to skip certian tests base on Tag#425
xiangyushawn merged 3 commits intomicrosoft:devfrom
xiangyushawn:give-option-to-skip-long-running-tests

Conversation

@xiangyushawn
Copy link
Copy Markdown
Contributor

@xiangyushawn xiangyushawn commented Aug 1, 2017 •
edited
Loading

give option to user to skip certain tests base on tags. (revised base on PR #114 )

For example, running the following command to build the driver will skip tests that are tagged as slow:

mvn clean install -Pbuild42 -DskipTestTag=slow

If -DskipTestTag is not provided in the command, all tests will be executed.

Will need to update ReadMe after next release.

@xiangyushawn xiangyushawn mentioned this pull request Aug 1, 2017
Closed
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 1, 2017 •
edited
Loading

Codecov Report

Merging #425 into dev will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #425      +/-   ##
============================================
- Coverage     45.92%   45.55%   -0.37%     
+ Complexity     2198     2141      -57     
============================================
  Files           108      108              
  Lines         25210    25210              
  Branches       4164     4164              
============================================
- Hits          11577    11484      -93     
+ Misses        11711    11682      -29     
- Partials       1922     2044     +122
Flag Coverage Δ Complexity Δ
#JDBC41 45.31% <ø> (-0.37%) 2132 <ø> (-53)
#JDBC42 45.44% <ø> (-0.37%) 2139 <ø> (-53)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 51.11% <0%> (-5.19%) 11% <0%> (-5%)
...ava/com/microsoft/sqlserver/jdbc/ScrollWindow.java 73.17% <0%> (-2.44%) 17% <0%> (-2%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.78% <0%> (-1.47%) 0% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 58.96% <0%> (-1.08%) 87% <0%> (-4%)
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java 68.46% <0%> (-0.91%) 0% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerResultSetMetaData.java 40.97% <0%> (-0.7%) 23% <0%> (-1%)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.31% <0%> (-0.64%) 272% <0%> (-16%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.48% <0%> (-0.51%) 238% <0%> (-5%)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.06% <0%> (-0.51%) 129% <0%> (-9%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 49.33% <0%> (-0.34%) 155% <0%> (-8%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7741ee9...6f57b27. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 1, 2017 •
edited
Loading

Codecov Report

Merging #425 into dev will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #425      +/-   ##
============================================
- Coverage     45.92%   45.55%   -0.37%     
+ Complexity     2198     2141      -57     
============================================
  Files           108      108              
  Lines         25210    25210              
  Branches       4164     4164              
============================================
- Hits          11577    11484      -93     
+ Misses        11711    11682      -29     
- Partials       1922     2044     +122
Flag Coverage Δ Complexity Δ
#JDBC41 45.31% <ø> (-0.37%) 2132 <ø> (-53)
#JDBC42 45.44% <ø> (-0.37%) 2139 <ø> (-53)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 51.11% <0%> (-5.19%) 11% <0%> (-5%)
...ava/com/microsoft/sqlserver/jdbc/ScrollWindow.java 73.17% <0%> (-2.44%) 17% <0%> (-2%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.78% <0%> (-1.47%) 0% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 58.96% <0%> (-1.08%) 87% <0%> (-4%)
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java 68.46% <0%> (-0.91%) 0% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerResultSetMetaData.java 40.97% <0%> (-0.7%) 23% <0%> (-1%)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.31% <0%> (-0.64%) 272% <0%> (-16%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.48% <0%> (-0.51%) 238% <0%> (-5%)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.06% <0%> (-0.51%) 129% <0%> (-9%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 49.33% <0%> (-0.34%) 155% <0%> (-8%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7741ee9...6f57b27. Read the comment docs.

nsidhaye
nsidhaye reviewed Aug 2, 2017
View reviewed changes
pom.xml

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<junit.platform.version>1.0.0-M3</junit.platform.version>
Copy link
Copy Markdown
Contributor

@nsidhaye nsidhaye Aug 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super !!!

I like this. In future you will able to use maven versioning plugin to upgrade latest 3rd party dependencies

@xiangyushawn xiangyushawn merged commit dfbf439 into microsoft:dev Aug 10, 2017
@xiangyushawn xiangyushawn deleted the give-option-to-skip-long-running-tests branch August 10, 2017 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@nsidhaye nsidhaye nsidhaye left review comments

@AfsanehR-zz AfsanehR-zz AfsanehR-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@xiangyushawn @codecov-io @nsidhaye @AfsanehR-zz @lilgreenbird @msftclas @ajlam @meet-bhagdev