Skip to content

fix an small issue with SQL Variant#424

Merged
xiangyushawn merged 1 commit intomicrosoft:devfrom
xiangyushawn:fix-a-SQL-Variant-mistake
Aug 8, 2017
Merged

fix an small issue with SQL Variant#424
xiangyushawn merged 1 commit intomicrosoft:devfrom
xiangyushawn:fix-a-SQL-Variant-mistake

Conversation

@xiangyushawn
Copy link
Copy Markdown
Contributor

@xiangyushawn xiangyushawn commented Jul 31, 2017

missed this during code review and saw this later when doing another implementation.

This does not break anything, just improper way to use enum

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 31, 2017

Codecov Report

Merging #424 into dev will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #424      +/-   ##
============================================
+ Coverage     45.92%   46.04%   +0.12%     
- Complexity     2198     2206       +8     
============================================
  Files           108      108              
  Lines         25210    25210              
  Branches       4164     4164              
============================================
+ Hits          11577    11608      +31     
+ Misses        11711    11687      -24     
+ Partials       1922     1915       -7
Flag Coverage Δ Complexity Δ
#JDBC41 45.84% <100%> (+0.16%) 2193 <0> (+8) ⬆️
#JDBC42 45.82% <100%> (+0.01%) 2197 <0> (+5) ⬆️
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.48% <100%> (-0.13%) 0 <0> (ø)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 54.81% <0%> (-1.49%) 15% <0%> (-1%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 59.61% <0%> (-0.44%) 90% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.86% <0%> (-0.13%) 242% <0%> (-1%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 49.91% <0%> (+0.25%) 163% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.87% <0%> (+0.3%) 139% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.58% <0%> (+0.33%) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.58% <0%> (+0.44%) 256% <0%> (+5%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 59.01% <0%> (+1.28%) 56% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7741ee9...91d17d1. Read the comment docs.

@xiangyushawn xiangyushawn merged commit d045d1a into microsoft:dev Aug 8, 2017
@xiangyushawn xiangyushawn deleted the fix-a-SQL-Variant-mistake branch August 8, 2017 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xiangyushawn @codecov-io @lilgreenbird @msftclas @ajlam @meet-bhagdev