Skip to content

Get string issue for uniqueidentifier#423

Merged
xiangyushawn merged 3 commits intomicrosoft:devfrom
xiangyushawn:getString-issue-for-uniqueidentifier
Aug 10, 2017
Merged

Get string issue for uniqueidentifier#423
xiangyushawn merged 3 commits intomicrosoft:devfrom
xiangyushawn:getString-issue-for-uniqueidentifier

Conversation

@xiangyushawn
Copy link
Copy Markdown
Contributor

@xiangyushawn xiangyushawn commented Jul 31, 2017

for issue #405

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 31, 2017

Codecov Report

Merging #423 into dev will increase coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #423      +/-   ##
============================================
+ Coverage     45.92%   45.95%   +0.02%     
- Complexity     2198     2200       +2     
============================================
  Files           108      108              
  Lines         25210    25212       +2     
  Branches       4164     4165       +1     
============================================
+ Hits          11577    11585       +8     
+ Misses        11711    11708       -3     
+ Partials       1922     1919       -3
Flag Coverage Δ Complexity Δ
#JDBC41 45.77% <85.71%> (+0.08%) 2194 <0> (+9) ⬆️
#JDBC42 45.84% <85.71%> (+0.03%) 2193 <0> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.16% <85.71%> (-0.44%) 0 <0> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 37.97% <0%> (-2.25%) 83% <0%> (-3%)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75.6% <0%> (-1.63%) 28% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 54.81% <0%> (-1.49%) 15% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.8% <0%> (-0.2%) 242% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.18% <0%> (+0.04%) 252% <0%> (+1%) ⬆️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.64% <0%> (+0.21%) 47% <0%> (+1%) ⬆️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 49.91% <0%> (+0.25%) 163% <0%> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.68% <0%> (+0.43%) 0% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7741ee9...133afdc. Read the comment docs.

@xiangyushawn xiangyushawn merged commit ca55cc3 into microsoft:dev Aug 10, 2017
@xiangyushawn xiangyushawn deleted the getString-issue-for-uniqueidentifier branch August 10, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AfsanehR-zz AfsanehR-zz AfsanehR-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@xiangyushawn @codecov-io @AfsanehR-zz @lilgreenbird @msftclas @ajlam @meet-bhagdev