Skip to content

Sslprotocol#325

Closed
v-nisidh wants to merge 4 commits intomicrosoft:devfrom
v-nisidh:SSLProtocol
Closed

Sslprotocol#325
v-nisidh wants to merge 4 commits intomicrosoft:devfrom
v-nisidh:SSLProtocol

Conversation

@v-nisidh
Copy link
Copy Markdown
Contributor

@v-nisidh v-nisidh commented Jun 1, 2017

Please DO NOT MERGE. This Pull Request is only for review for approach taken for IBM FIPS & SSL Protocol

v-nisidh added 4 commits May 10, 2017 18:58
@v-nisidh
Initial Checkin
c5dc369 
Initial check in for configurable SSLProtocols
@v-nisidh
Added parametrized test cases
f9ea4ac 
Added parametrized test cases
@v-nisidh
For IBM FIPS
d6d7f0e 
In IBM FIPS environment IBM JRE expects FIPSProvider should be read from
JVM config files.
@v-nisidh
Disable Some tests
11ea2c7 
Disabled some test for FIPS env. due to change in logic. Need to write
tests for FIPS
@v-nisidh
Copy link
Copy Markdown
Contributor Author

v-nisidh commented Jun 1, 2017

Please find attach files for test purpose.

Shared_Files.zip

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 2, 2017 •
edited
Loading

Codecov Report

Merging #325 into dev will decrease coverage by 0.11%.
The diff coverage is 52.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #325      +/-   ##
============================================
- Coverage     37.26%   37.14%   -0.12%     
+ Complexity     1764     1762       -2     
============================================
  Files           107      107              
  Lines         24491    24507      +16     
  Branches       4000     4001       +1     
============================================
- Hits           9127     9104      -23     
- Misses        13653    13698      +45     
+ Partials       1711     1705       -6
Flag Coverage Δ Complexity Δ
#JDBC41 37.05% <52.38%> (-0.11%) 1757 <0> (-3)
#JDBC42 37.01% <52.38%> (-0.14%) 1753 <0> (-5)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 43.51% <0%> (-3.9%) 59 <0> (-7)
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 74.18% <100%> (+0.23%) 25 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 44.62% <28.57%> (+0.03%) 255 <0> (+1) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 43.45% <75%> (-0.87%) 0 <0> (ø)
...java/com/microsoft/sqlserver/jdbc/StringUtils.java 0% <0%> (-60%) 2% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 29.24% <0%> (-1.12%) 55% <0%> (-1%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a12a39...11ea2c7. Read the comment docs.

@xiangyushawn xiangyushawn reopened this Jul 5, 2017
@v-nisidh
Copy link
Copy Markdown
Contributor Author

v-nisidh commented Jul 7, 2017

This pull request consists of adding configurable SSLProtocol and removing FIPS validation.

Please create 2 different pull requests for SSLProtocol & removing FIPS validation

@xiangyushawn xiangyushawn self-requested a review July 17, 2017 22:46
@ulvii
Copy link
Copy Markdown
Contributor

ulvii commented Jul 31, 2017 •
edited by ajlam
Loading

Hi @v-nisidh/ @nsidhaye

I created a new PR that adds sslProtocol connection property. Planing to create another one for FIPS validation. Please feel free to leave your feedback :)

@ulvii ulvii closed this Jul 31, 2017
@ulvii ulvii mentioned this pull request Aug 12, 2017
Closed
@nsidhaye nsidhaye mentioned this pull request Aug 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangyushawn xiangyushawn Awaiting requested review from xiangyushawn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@v-nisidh @codecov-io @ulvii @lilgreenbird @msftclas @ajlam @xiangyushawn