Skip to content

Add fips connection property#135

Merged
v-nisidh merged 3 commits intomicrosoft:devfrom
v-nisidh:fips1.1
Feb 7, 2017
Merged

Add fips connection property#135
v-nisidh merged 3 commits intomicrosoft:devfrom
v-nisidh:fips1.1

Conversation

@v-nisidh
Copy link
Copy Markdown
Contributor

@v-nisidh v-nisidh commented Feb 5, 2017

Add bunch of negtive test cases & reduced property parameters in case installed certificate for FIPS enabled JVM

@v-nisidh
Add fips property
c68cdd6 
Add fips property whcih is very useful in case of installed
certificates.
@v-nisidh
Adding FIPS Test cases & finer logging statements.
8bc2d60
@v-nisidh v-nisidh modified the milestone: 6.1.4 Feb 5, 2017
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 7, 2017

Codecov Report

❗ No coverage uploaded for pull request base (dev@2779416). Click here to learn what that means.

@@          Coverage Diff           @@
##             dev     #135   +/-   ##
======================================
  Coverage       ?   27.31%           
  Complexity     ?     1132           
======================================
  Files          ?       95           
  Lines          ?    23268           
  Branches       ?     3870           
======================================
  Hits           ?     6356           
  Misses         ?    15625           
  Partials       ?     1287
Flag Coverage Δ Complexity Δ
#JDBC41 27.22% <61.29%> (?) 1127 <ø> (?)
#JDBC42 27.15% <61.29%> (?) 1130 <ø> (?)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <ø> (?)
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 70.97% <100%> (ø) 23 <ø> (?)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 31.57% <57.14%> (ø) 0 <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2779416...bff2c5b. Read the comment docs.

@v-nisidh v-nisidh merged commit 8a9ea96 into microsoft:dev Feb 7, 2017
@v-nisidh v-nisidh deleted the fips1.1 branch February 10, 2017 21:44
@v-nisidh
Copy link
Copy Markdown
Contributor Author

v-nisidh commented Feb 10, 2017

Thanks @ErikBergfurInfor for identifying missing implementation.

@v-nisidh
Copy link
Copy Markdown
Contributor Author

v-nisidh commented Feb 10, 2017

@ErikBergfurInfor I added above properties in SQLServerDataSource. Only change is I am using Boolean return value for getFips. I will create Pull Request to merge to dev after creating bunch of test cases.

ref: v-nisidh@6789957

@v-nisidh
Copy link
Copy Markdown
Contributor Author

v-nisidh commented Feb 13, 2017

@ErikBergfurInfor I merge above changes dev branch.

@ulvii ulvii mentioned this pull request Aug 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.1.4

Development

Successfully merging this pull request may close these issues.

4 participants

@v-nisidh @codecov-io @ErikBergfurInfor @lilgreenbird