Fix | Fixed PreparedStatement exception handling#1003
Merged
ulvii merged 5 commits intomicrosoft:devfrom Apr 10, 2019
Merged
Conversation
This was referenced Mar 22, 2019
Codecov Report
@@ Coverage Diff @@
## dev #1003 +/- ##
============================================
- Coverage 50.19% 50.13% -0.06%
+ Complexity 2885 2881 -4
============================================
Files 120 120
Lines 27989 27984 -5
Branches 4677 4675 -2
============================================
- Hits 14050 14031 -19
- Misses 11684 11696 +12
- Partials 2255 2257 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #1003 +/- ##
============================================
- Coverage 50.76% 50.73% -0.04%
+ Complexity 2960 2959 -1
============================================
Files 120 120
Lines 27999 27994 -5
Branches 4685 4683 -2
============================================
- Hits 14215 14203 -12
- Misses 11626 11638 +12
+ Partials 2158 2153 -5
Continue to review full report at Codecov.
|
cheenamalhotra
previously approved these changes
Apr 9, 2019
lilgreenbird
previously approved these changes
Apr 9, 2019
rene-ye
previously approved these changes
Apr 9, 2019
b9a4d83
src/test/java/com/microsoft/sqlserver/jdbc/exception/ExceptionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/exception/ExceptionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/exception/ExceptionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/exception/ExceptionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/exception/ExceptionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/exception/ExceptionTest.java
Outdated
Show resolved
Hide resolved
peterbae
previously approved these changes
Apr 10, 2019
peterbae
approved these changes
Apr 10, 2019
cheenamalhotra
approved these changes
Apr 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #995, reverts #664.
When there is an exception in a result set, it should only be parsed when the cursor is moved to that result set. This PR also makes Statement and PreparedStatement behavior consistent with each other.