[CP] Persists the virtual buffer size when switching to app owned buffers #5690#5719
Merged
guhetier merged 2 commits intorelease/2.5from Jan 16, 2026
Merged
[CP] Persists the virtual buffer size when switching to app owned buffers #5690#5719guhetier merged 2 commits intorelease/2.5from
guhetier merged 2 commits intorelease/2.5from
Conversation
Co-authored-by: Michael Friesen <3517159+mtfriesen@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/2.5 #5719 +/- ##
===============================================
- Coverage 87.25% 86.17% -1.09%
===============================================
Files 59 59
Lines 18207 18209 +2
===============================================
- Hits 15887 15692 -195
- Misses 2320 2517 +197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtfriesen
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an endpoint receives a new stream indication, it can provide some receive buffers inline to convert the stream to app-owned buffer mode.
When doing so, the receive buffer struct of the stream is reinitialized, and the virtual buffer length (which correspond to the stream receive window) was set to zero.
This is incorrect since we introduced the "more buffer needed" notification and the receive window is no longer tied to the amount of buffer provided.
This would result in a receive failure with data received outside of the virtual size.
When converting the receive buffer to app-buffer mode, the virtual size is now preserved.
Fixes #5672.
Testing
Test not backported as they rely on changes present only in main
Documentation
Clarify documentation about the app provided receive buffer ownership.