CP: Do not always enable DSCP on Recv#5493
Merged
ProjectsByJackHe merged 2 commits intorelease/2.5from Oct 7, 2025
Merged
Conversation
* work-around to add recv dscp * posix * wip * linux packages?c * posix * proper init * respond to feedback * more nit feedback, remove hard-coded TRUE * comments * fix build * fix winkernel build * wip * wip * address comments
f2fd626 to
15a6f78
Compare
guhetier
reviewed
Oct 6, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/2.5 #5493 +/- ##
===============================================
- Coverage 87.42% 86.89% -0.54%
===============================================
Files 59 59
Lines 18173 18188 +15
===============================================
- Hits 15888 15804 -84
- Misses 2285 2384 +99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guhetier
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CP of: #5467
Description copied for convenience:
DSCP on Recv, when enabled, seriously regresses performance.
At the same time, we cannot just delete the code.
So let's come to a compromise and only enable it via a global SetParam.
Most users of MsQuic SHOULD NOT set this on. But we set it on in our CI so our test code can exercise DSCP.
Testing
CI
Documentation
N/A