[release/2.3] Don't send client CONNECTION_CLOSE on 1-RTT before handshake completion. (#4145) #4164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.3 #4164 +/- ##
===============================================
- Coverage 87.35% 86.74% -0.61%
===============================================
Files 56 56
Lines 16984 16987 +3
===============================================
- Hits 14837 14736 -101
- Misses 2147 2251 +104 ☔ View full report in Codecov by Sentry. |
Member
Author
|
We should probably hold on this before merging, the fix I did may not be enough in some cases (see dotnet/runtime#99074) |
Member
Author
|
False alarm, we hit a slightly different bug: #4166 which can be fixed separately. |
nibanks
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #4145 to release/2.3