Skip to content

new API for async certificate validation #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ami-GS merged 3 commits into from
Jan 1, 2023
Merged

new API for async certificate validation #3318

ami-GS merged 3 commits into from
Jan 1, 2023

Conversation

@ami-GS
Copy link
Contributor

@ami-GS ami-GS commented Dec 31, 2022

Description

Async certificate validation

Testing

Documentation

@ami-GS ami-GS marked this pull request as ready for review December 31, 2022 14:08
@ami-GS ami-GS requested a review from a team as a code owner December 31, 2022 14:08
@ami-GS ami-GS added Area: Documentation Area: API Language: C# Related to the C# interop layer Language: Rust Related to the Rust interop layer labels Dec 31, 2022
@ami-GS ami-GS merged commit 97616f7 into microsoft:main Jan 1, 2023
@nibanks
Copy link
Collaborator

nibanks commented Jan 1, 2023

It looks like this PR actually broke the tests @ami-GS:

Note: Google Test filter = Handshake/WithHandshakeArgs5.CustomCertificateValidation/1
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
Initializing for User Mode tests
[----------] 1 test from Handshake/WithHandshakeArgs5
[ RUN      ] Handshake/WithHandshakeArgs5.CustomCertificateValidation/1
D:\a\1\msquic\src\test\lib\HandshakeTest.cpp(803): error: Client.SetCustomValidationResult(AcceptCert) failed, 0x8007139f
[  FAILED  ] Handshake/WithHandshakeArgs5.CustomCertificateValidation/1, where GetParam() = Reject/Async (1038 ms)
[----------] 1 test from Handshake/WithHandshakeArgs5 (1038 ms total)

Can you please make a PR to fix them? Thanks!

@ami-GS
Copy link
Contributor Author

ami-GS commented Jan 1, 2023

let me quickly fix

@rzikm rzikm mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nibanks nibanks nibanks approved these changes

Assignees

No one assigned

Labels

Area: API Area: Documentation Language: C# Related to the C# interop layer Language: Rust Related to the Rust interop layer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ami-GS @nibanks