Updates to support the TS 3.6.0 beta, and adds a daily run-script #36
Updates to support the TS 3.6.0 beta, and adds a daily run-script #36alexdima merged 11 commits intomicrosoft:masterfrom
Conversation
|
This is currently blocked because I can't add a pipeline to this repo, so I applied to join the vscode team in the ms GitHub org yesterday |
|
OK, I've verified this on my own pipelines to be working 👍 I'd need to re-create the pipelines on this repo, and add an NPM token to the environment after this is merged. |
alexdima
left a comment
There was a problem hiding this comment.
I get a compile error in languageFeatures.ts. It looks like the code is written against TS 3.6, but in package.json we still ask for TS ^3.5.1, so is there a way to write languageFeatures.ts in a way which works against both versions?
|
Ah yeah, I remember now, I didn't want to have to send along all of the changes of TypeScript 3.6 in this PR when it was still in a beta phase - and so I didn't ship the package.json change. The RC should be today, so I'm happy to have that happen once that that's shipped. I can give it a shot at handling both forms of diagnostics but it's probably not worth it given that it will only be used with 3.6+ form here on out |
orta
left a comment
There was a problem hiding this comment.
Alright, this is ready to go with the 3.6 release 👍
| const beforeProcess = `ts.perfLogger.logInfoEvent("Starting TypeScript v" + ts.versionMajorMinor + " with command line: " + JSON.stringify(process.argv));` | ||
| const afterProcess = `// MONACOCHANGE\n ts.perfLogger.logInfoEvent("Starting TypeScript v" + ts.versionMajorMinor + " with command line: " + JSON.stringify([]));\n// END MONACOCHANGE` | ||
| tsServices = tsServices.replace(beforeProcess, afterProcess); | ||
|
|
There was a problem hiding this comment.
I'm about to send a TS PR to fix this upstream also 👍
src/languageFeatures.ts
Outdated
| } | ||
| result += diagnosticChain.messageText; | ||
| indent++; | ||
| diagnosticChain = diagnosticChain.next; |
There was a problem hiding this comment.
This retains the backwards compatibility with 3.5 and below ( by just using an any and keeping the original logic if the next isn't utterable (here's a screenshot of it in 3.5 still chaining correctly )
mjbvz
left a comment
There was a problem hiding this comment.
LGTM
@alexandrudima Is having a daily build of this published good with you?
…escript it ships and reflects its own API surface
…escript it ships and reflects its own API surface
|
|
Thank you! ❤️ |
|
Thank you! |
ts.DiagnosticMessageChainnow supports nested diagnostics, so I moved over the new function from TS.