Open
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
@microsoft-github-policy-service agree |
|
anyone? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
TOML is not supported
Fix
Support TOML
References taken from
Valiation
Unit tests added according to https://toml.io/en/v1.0.0. Most of the tests are taken directly from the examples in the spec, but some are tweaked to have more coverage.
Also tested in a testing app with vs-dark and light theme
vs-dark
vs
Other
Closes #2798
This is my first monarch language. I didn't do benchmark on performance but it can probably be made faster. However I just made the states in the way it made sense in my head.
The sample file is taken from https://github.com/rust-lang/rust/blob/master/triagebot.toml, which covers a lot of the interesting cases