Fix #2851 Highlight correctly the attributes and identifiers (with dashes) for Shell language#2871
Merged
alexdima merged 1 commit intomicrosoft:mainfrom Jan 27, 2022
Merged
Conversation
|
|
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix #2851. The fix is correcting the regex that highlight the attributes and create a new regex for identifiers containing dashes.
This impact the Monaco editor playground only.
You can test by running the tests:
Two new tests added, one for the bug reported and one for the new regex defined (identifiers with dashes).