Add UnifiedMessage support for iperf3 TCP and UDP performance metrics#4058
Add UnifiedMessage support for iperf3 TCP and UDP performance metrics#4058
Conversation
Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
…ions_num as parameter Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
squirrelsc
left a comment
There was a problem hiding this comment.
@copilot resolve conflicts with main branch
…essage-network-tcp
…r_size metrics Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
Merged main branch successfully. The merge added MetricRelativity.Parameter enum which is now used for parameter-type metrics. (commit 59068fe) |
Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
|
@LiliDeng LGTM |
|
@copilot please rebase the code from main branch. |
Synced successfully with the latest code from main branch. (commit 3f6ceb2) |
|
@copilot rebase from latest main, don't show the commits from the main branch, just show the commits changed for this PR. |
Rebased on latest main with clean commit history. The PR now shows only 1 commit with the iperf3 changes on top of main branch, without showing commits from main. (commit 48f7524)
I've prepared a clean rebase with just 1 commit for the PR changes on top of main (commit e21f8cc), but the automated push tool doesn't support force-push which is needed to replace the remote branch history. The current remote branch shows 56 commits because previous rebase operations cherry-picked commits from main with different SHAs. The actual code changes are correct - only iperf3.py is modified with the unified message support. To complete the cleanup, you'll need to either:
The local branch is ready at commit e21f8cc with a clean single-commit history on top of main. |
|
@copilot Please merge the main branch. |
…/add-unified-message-network-tcp
- Remove separate connections_num and buffer_size_bytes metrics
- Add suffix format: _conn_{connections_num}_buffer_{buffer_size}
- Apply suffix to all TCP metrics: rx/tx_throughput_in_gbps, congestion_windowsize_kb, retransmitted_segments
- Apply suffix to all UDP metrics: rx/tx_throughput_in_gbps, data_loss
- This allows distinguishing results by connection count and buffer size
Co-authored-by: LiliDeng <10083705+LiliDeng@users.noreply.github.com>
|
@copilot please fix the flake8 error |
- Remove trailing whitespace from line 492 in send_iperf3_tcp_unified_perf_messages - Remove trailing whitespace from line 534 in send_iperf3_udp_unified_perf_messages - Fixes W293 flake8 warnings and BLK100 black formatting issue Co-authored-by: LiliDeng <10083705+LiliDeng@users.noreply.github.com>
... Fixed flake8 errors by removing trailing whitespace from blank lines at lines 492 and 534. (commit pending)
... Fixed flake8 errors by removing trailing whitespace from blank lines at lines 492 and 534. (commit b2d9449) |
This PR adds unified performance message support to the iperf3 tool, bringing it into alignment with ntttcp which already has this functionality.
Changes
MetricRelativity,TransportProtocol,send_unified_perf_messagesend_iperf3_tcp_unified_perf_messages()for TCP metricssend_iperf3_udp_unified_perf_messages()for UDP metrics_send_unified_perf_metrics()create_iperf_tcp_performance_message()to call unified sendercreate_iperf_udp_performance_message()to call unified sender_conn_{connections_num}_buffer_{buffer_size}TCP Metrics
All metrics include suffix
_conn_{connections_num}_buffer_{buffer_size}:UDP Metrics
All metrics include suffix
_conn_{connections_num}_buffer_{buffer_size}:Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.