-
Notifications
You must be signed in to change notification settings - Fork 923
Closed
Labels
clarificationhelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesrename
Description
I have a question about properly handling errors in textDocument/rename. I wonder how server should respond to following scenarios:
- When
textDocumentorpositioninRenameParamsin invalid (not existing file, position out of bound, etc.) - When there is a compile error in the project, and we are unable to actually perform any renames
- When the
positionpoints to a symbol that can't be renamed (e.g. we point to an space character) - What error code should be used if
newNameis invalid?
Also, the server returns result: WorkspaceEdit | null - what is the valid use of null? Is it when there is nothing to change, or for some of the cases above?
Would it be useful to clarify those in the actual specification, maybe giving some examples?
Metadata
Metadata
Assignees
Labels
clarificationhelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesrename