To be totally clear, I'm not a python developer this is all copilot 😄

Conflicts have been resolved. A maintainer will take a look shortly.

@baywet is there a command to apply the wanted code formatting? I see it's failing at that.

@svrooij should be something like yapf -ir .

@svrooij a few files were forgotten about:

• packages\serialization\form\tests\unit\test_form_serialization_writer.py
• packages\serialization\json\kiota_serialization_json\json_serialization_writer.py
• packages\serialization\json\tests\unit\test_json_parse_node.py
• packages/serialization/multipart/pyproject.toml
• packages\serialization\json\tests\unit\test_json_serialization_writer.py

@svrooij there are additional CI issues, would you mind having a look at it please?

This is related to #453 being able to run the tests locally would greatly reduce the developer feedback flow.

@svrooij there are still tests failing for form and json, would you mind having a look whenever you have some time please?

The tests are failing because [datetime.]time.fromisoformat accepted a limited set of formats in Python 3.9 and 3.10.

In particular, the tests specify

    "startWorkTime=08:00:00.0000000&"
    "endWorkTime=17:00:00.0000000&"

but on older python, the fractional second part is only allowed to have either 3 or 6 digits, and we specify 7.

An option would be, if we are on an older python and there is a fractional part ("."), then we cut it to 6 if the input string is longer than 6, or pad it with zeros to 6 if it is shorter

thanks for chiming in @danieleds !!

to achieve this, would you add a condition like this one in the code?

@baywet would love to, but I don't think I have push permissions on this branch

To be clear, I was only asking about how you'd do it, so @svrooij has all the elements.
We only have very few changes left for this to be complete IMHO, I don't think having multiple people working on it is going to be super productive, especially when we consider the overhead of either setting permissions or sending PRs to a fork.
Of course, if @svrooij needs more help than this guidance, we might re-evaluate at a later point.
Does that make sense?

Oh I see. Yes, that's exactly what I had in mind. Something like, in form_parse_node.py and similar files:

if sys.version_info[:3] <= (3,10):
    fixed_time = re.sub(r'(\d[.,])(\d+)', lambda x: x.group(1) + x.group(2).ljust(6,'0')[:6], self._node)
    return time.fromisoformat(fixed_time)
else:
    return time.fromisoformat(self._node)

(untested)

Oh I see. Yes, that's exactly what I had in mind. Something like, in form_parse_node.py and similar files:

if sys.version_info[:3] <= (3,10):
    fixed_time = re.sub(r'(\d[.,])(\d+)', lambda x: x.group(1) + x.group(2).ljust(6,'0')[:6], self._node)
    return time.fromisoformat(fixed_time)
else:
    return time.fromisoformat(self._node)

(untested)

Thanks @danieleds for your input.
Since that code is used multiple times, I added it to the date_utls file.

8aaeff1#diff-8acdec4a0f6630bb416ac06117c85639c6656c1f65ef249c859dad74bc82c0ccR82-R98

@svrooij I did have a question: when I approve the CI and it fails, do you receive notifications on your end or not? I don't want to double down in case you're already receiving those :)

@baywet I only get notifications from reactions (yours and sonarqube)

@svrooij Thanks for confirming. That's what I suspected since I get the notifications when the CI fails. So I'll keep notifying you here if that works for you.

And yes, the CI failed again :)

Going to download a python 3.9 dev container and run the tests there.

@svrooij looks like in the regex we also need to replace the "," with "." for older python.

Also I realized my python version check was slightly wrong, I suggest using the following instead: if sys.version_info[:3] < (3,11): (so that all patch versions of 3.10 do match too)

something like this

fixed_time = re.sub(r'(\d)([.,])(\d+)', lambda x: x.group(1) + "." + x.group(3).ljust(6,'0')[:6], self._node)

@baywet It seems I do get the notification about failures inside github but not in my mail. Probably disabled that a long time ago.

Still seeing issues with unit tests. Could it be that Z is not supported for date time parsing in older versions?
Also might need some additional work for forms tests on times

@baywet It seems I do get the notification about failures inside github but not in my mail. Probably disabled that a long time ago.

ah ok! I'll stop posting here then to avoid spamming you

@danieleds and strip of the Z?

FAILED tests/unit/test_json_parse_node.py::test_get_collection_of_object_values - ValueError: Invalid isoformat string: '2021-07-29T03:07:25Z'

@svrooij yes I think that's the issue. Instead of stripping the "Z", you may consider replacing it with "+00:00" so that we retain the timezone information

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

It really helps that I'm now able to run all the tests locally in Python 3.9, only 1 error left and that is because an assertion tried to parse a datetime string with a z to compare

And sorry for spamming.