fix: grab the first value if the server response contains a comma (#482)

MarcoP9 · baywet · web-flow · commit dc32a10e03e3 · 2025-06-27T08:55:32.000-07:00
* fix: grab the first value if the serve response contains a comma

* test: Add test on the retry handler when handling comma separated values

* fix: make the comma check more specific through a regex

* chore: relaxes regex

---------

Co-authored-by: Vincent Biret &lt;vibiret@microsoft.com&gt;
Co-authored-by: Vincent Biret &lt;vincentbiret@hotmail.com&gt;
diff --git a/packages/http/httpx/kiota_http/middleware/retry_handler.py b/packages/http/httpx/kiota_http/middleware/retry_handler.py
@@ -1,5 +1,6 @@
 import datetime
 import random
+import re
 import time
 from email.utils import parsedate_to_datetime
 
@@ -202,6 +203,9 @@ def _parse_retry_after(self, retry_after):
         Helper to parse Retry-After and get value in seconds.
         """
         try:
+            retry_after = retry_after.split(",")[0] if re.match(
+                r"\d+,\d+$", retry_after
+            ) else retry_after
             delay = int(retry_after)
         except ValueError:
             # Not an integer? Try HTTP date
diff --git a/packages/http/httpx/tests/middleware_tests/test_retry_handler.py b/packages/http/httpx/tests/middleware_tests/test_retry_handler.py
@@ -142,6 +142,16 @@ def test_get_retry_after_no_header():
     assert retry_handler._get_retry_after(response) is None
 
 
+def test_get_retry_after_string_with_comma():
+    """
+    Test the _get_retry_after method with string 30,120 as Retry-After value.
+    """
+    response = httpx.Response(TOO_MANY_REQUESTS, headers={RETRY_AFTER: f'30,120'})
+
+    retry_handler = RetryHandler()
+    assert retry_handler._get_retry_after(response) == 30
+
+
 def test_get_retry_after_http_date():
     """
     Test the _get_retry_after method with a http date as Retry-After value.
