feat: Add retry delay as span attribute in retry handler#180
Merged
baywet merged 3 commits intomicrosoft:mainfrom Aug 13, 2024
Merged
feat: Add retry delay as span attribute in retry handler#180baywet merged 3 commits intomicrosoft:mainfrom
baywet merged 3 commits intomicrosoft:mainfrom
Conversation
baywet
requested changes
Aug 12, 2024
Member
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Here are a couple of suggestions.
In addition to this, can you also please:
- bump the version in the user agent options (patch)
- add an entry in the changelog entry (today's date, patch version, changed)
Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>
Contributor
Author
|
@microsoft-github-policy-service agree company="MIND" |
Contributor
Author
|
Thanks for the review! Added the requested changes. |
baywet
approved these changes
Aug 13, 2024
Member
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.