Adds IAsyncParseNodeFactory, makes deserialization methods async, upd…#225
Adds IAsyncParseNodeFactory, makes deserialization methods async, upd…#225andrueastman merged 13 commits intomicrosoft:mainfrom MihaMarkic:feature/asyncdeserialization
Conversation
baywet
left a comment
There was a problem hiding this comment.
Thanks for getting things started, a couple of comments.
baywet
left a comment
There was a problem hiding this comment.
Thanks for making the changes, one additional comment besides the obsolete discussion for consistency
baywet
left a comment
There was a problem hiding this comment.
Thanks for making the changes, a couple of last remarks and we should be good.
Also, can you please:
- add a changelog entry (changed, patch, monday)
- bump the version (patch)
I think we should preview/validate the changes for the JSON serialization library before we merge this one in, just in case we missed something, so we can validate the design. Thoughts?
|
@andrueastman for final review and merge! |
andrueastman
left a comment
There was a problem hiding this comment.
Thanks for the contribution here @MihaMarkic
Adds async deserialization capabilities