Merged
Conversation
This was
linked to
issues
Oct 13, 2021
Closed
44fb2aa to
7cf09fc
Compare
01bcdbc to
9cde5f0
Compare
f78c917 to
6d5af92
Compare
3fa4980 to
1422334
Compare
Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
Member
Author
|
@andrueastman FYI the major revamp on middleware infrastructure is done thanks to @jobala suggestion. Now the only thing that's left is to add a retry handler and parameter set support. |
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
jobala
reviewed
Oct 29, 2021
jobala
reviewed
Oct 29, 2021
Member
Author
|
@andrueastman we should be good to go for final review at this point. Thanks for the continuous support. |
jobala
reviewed
Oct 31, 2021
andrueastman
reviewed
Nov 1, 2021
Contributor
andrueastman
left a comment
There was a problem hiding this comment.
Save for the active comments, this looks good to me.
andrueastman
previously approved these changes
Nov 1, 2021
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
|
Kudos, SonarCloud Quality Gate passed! |
jobala
approved these changes
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #468, #465, #464, #463
Generation diff
microsoft/kiota-samples#364