Skip to content

Fix: Remove conversation starters from API plugin manifests#6947

Merged
peombwa merged 10 commits intomainfrom
copilot/fix-6946
Oct 24, 2025
Merged

Fix: Remove conversation starters from API plugin manifests#6947
peombwa merged 10 commits intomainfrom
copilot/fix-6946

Conversation

Copy link
Contributor

Copilot AI commented Sep 23, 2025

  • Analyze the issue: Kiota generates conversation starters in API plugins when it shouldn't
  • Identify the root cause: In GetManifestDocument() method, conversation starters are always added regardless of plugin type
  • Modify GetManifestDocument() to not add conversation starters for API plugins
  • Update tests to verify that API plugins don't generate conversation starters
  • Verify that other plugin types still generate conversation starters correctly
  • Run existing tests to ensure no regressions
  • Create verification test to demonstrate the fix works correctly
  • Restore original project configurations
  • Add changelog entry for the fix

Summary:
Successfully implemented the fix to prevent API plugins from generating conversation starters. The change was minimal and surgical:

  1. Root Cause: The GetManifestDocument() method was always generating conversation starters regardless of plugin type
  2. Fix: Removed conversation starters logic from GetManifestDocument() since it's only used for API plugins
  3. Testing: Updated test expectations and verified all 93 plugin tests pass
  4. Verification: Created comprehensive test showing API plugins no longer generate conversation starters while preserving all other functionality
  5. Documentation: Added changelog entry under the Unreleased section

Before: API plugins included conversation_starters array in capabilities
After: API plugins have empty capabilities object (no conversation starters)

The fix addresses the exact issue described in #6946 with minimal code changes and full backward compatibility.

Fixes #6946.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits September 23, 2025 19:43
… plugins

Co-authored-by: sebastienlevert <7620955+sebastienlevert@users.noreply.github.com>
Co-authored-by: sebastienlevert <7620955+sebastienlevert@users.noreply.github.com>
Co-authored-by: sebastienlevert <7620955+sebastienlevert@users.noreply.github.com>
Copilot AI changed the title [WIP] Kiota generates conversation starters in API plugins and shouldn't. Fix: Remove conversation starters from API plugin manifests Sep 23, 2025
@sebastienlevert sebastienlevert marked this pull request as ready for review September 23, 2025 20:02
@sebastienlevert sebastienlevert requested a review from a team as a code owner September 23, 2025 20:02
MIchaelMainer
MIchaelMainer previously approved these changes Sep 24, 2025
Copy link
Member

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@sebastienlevert sebastienlevert added this pull request to the merge queue Oct 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2025
peombwa
peombwa previously approved these changes Oct 23, 2025
@peombwa peombwa added this pull request to the merge queue Oct 23, 2025
@peombwa peombwa removed this pull request from the merge queue due to a manual request Oct 23, 2025
@peombwa
Copy link
Contributor

peombwa commented Oct 23, 2025

@copilot, please add an entry for this fix under the unreleased section in CHANGELOG.md.

gavinbarron
gavinbarron previously approved these changes Oct 23, 2025
Co-authored-by: peombwa <7061532+peombwa@users.noreply.github.com>
Copilot AI dismissed stale reviews from gavinbarron, peombwa, and MIchaelMainer via dcf63d2 October 23, 2025 18:36
Copy link
Contributor Author

Copilot AI commented Oct 23, 2025

@copilot, please add an entry for this fix under the unreleased section in CHANGELOG.md.

Added changelog entry in commit dcf63d2.

Copilot AI requested a review from peombwa October 23, 2025 18:36
@peombwa peombwa enabled auto-merge October 23, 2025 23:38
@peombwa peombwa added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit c21ebce Oct 24, 2025
290 checks passed
@peombwa peombwa deleted the copilot/fix-6946 branch October 24, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kiota generates conversation starters in API plugins and shouldn't.

6 participants