Skip to content

Add support for new properties in OpenApiAiAdaptiveCardExtension#6933

Merged
baywet merged 7 commits intomainfrom
copilot/fix-fce1a0f3-710f-4e96-bd1a-5ad680fe3510
Oct 23, 2025
Merged

Add support for new properties in OpenApiAiAdaptiveCardExtension#6933
baywet merged 7 commits intomainfrom
copilot/fix-fce1a0f3-710f-4e96-bd1a-5ad680fe3510

Conversation

Copy link
Contributor

Copilot AI commented Sep 19, 2025

Plan to add new properties to OpenApiAiAdaptiveCardExtension

Based on analysis of the code, I need to implement the following minimal changes to support the new CardResponseSemanticProperties interface:

  • Analyze existing code structure and patterns
  • Add SubTitle property to OpenApiAiAdaptiveCardExtension class
  • Add ThumbnailUrl property to OpenApiAiAdaptiveCardExtension class
  • Add InformationProtectionLabel property to OpenApiAiAdaptiveCardExtension class
  • Update Parse method to handle new properties in JSON parsing
  • Update Write method to serialize new properties
  • Update AdaptiveCardInfo record to include new properties
  • Update AdaptiveCardMapper to pass new properties
  • Update unit tests to cover new properties in parsing and serialization
  • Update plugin generation tests if needed
  • Verify all changes work correctly
  • Add changelog entry
  • Update changelog entry to reference issue Update the x-ai-adaptive-card extension schema to the latest supported one #6934

The new properties to add are:

  • subTitle?: string; ✅ Added as Subtitle
  • thumbnailUrl?: string; ✅ Added as ThumbnailUrl
  • informationProtectionLabel?: string; ✅ Added as InformationProtectionLabel

Note: title and url properties already exist in the current implementation.

Changes Made:

  • ✅ Added three new optional string properties to OpenApiAiAdaptiveCardExtension class
  • ✅ Updated Parse method to handle these properties from JSON with appropriate snake_case naming (subtitle, thumbnail_url, information_protection_label)
  • ✅ Updated Write method to serialize these properties with correct naming conventions
  • ✅ Updated AdaptiveCardInfo record to include the new properties as optional parameters
  • ✅ Updated AdaptiveCardMapper to pass the new properties to the record
  • ✅ Added comprehensive test coverage for parsing and serialization with all properties
  • ✅ Verified syntax and naming conventions are correct using test compilation
  • ✅ Ensured backward compatibility with existing functionality
  • ✅ Added changelog entry documenting the new feature
  • ✅ Updated changelog entry to reference issue Update the x-ai-adaptive-card extension schema to the latest supported one #6934

Summary:

All requirements have been successfully implemented with minimal changes that maintain backward compatibility. The new properties are optional and follow the existing patterns in the codebase for naming conventions, parsing, and serialization. A changelog entry has been added to document this new feature and references the related issue #6934.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…nailUrl, informationProtectionLabel

Co-authored-by: sebastienlevert <7620955+sebastienlevert@users.noreply.github.com>
Copilot AI changed the title [WIP] This file needs to support new properties. The x-ai-adaptive-card extension now supports these properties. interface CardResponseSemanticProperties { title?: string; subTitle?: string; url?: string; thumbnailUrl?: string; informationProtecti... Add support for new properties in OpenApiAiAdaptiveCardExtension Sep 19, 2025
@sebastienlevert
Copy link
Contributor

@copilot add a changelog entry

Co-authored-by: sebastienlevert <7620955+sebastienlevert@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Sep 19, 2025

@copilot add a changelog entry

Changelog entry added in commit a16f099. The entry documents the addition of three new properties (subtitle, thumbnailUrl, and informationProtectionLabel) to the OpenApiAiAdaptiveCardExtension class.

@sebastienlevert
Copy link
Contributor

@copilot add that it closes #6934

Co-authored-by: sebastienlevert <7620955+sebastienlevert@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Sep 19, 2025

@copilot add that it closes #6934

Updated the changelog entry in commit b1a2224 to include reference to issue #6934.

@sebastienlevert sebastienlevert marked this pull request as ready for review September 19, 2025 19:52
@sebastienlevert sebastienlevert requested a review from a team as a code owner September 19, 2025 19:52
@baywet baywet enabled auto-merge September 24, 2025 15:56
@baywet baywet added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit 46e5f97 Oct 23, 2025
290 checks passed
@baywet baywet deleted the copilot/fix-fce1a0f3-710f-4e96-bd1a-5ad680fe3510 branch October 23, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the x-ai-adaptive-card extension schema to the latest supported one

4 participants