Conversation
Closed
6 tasks
baywet
commented
Oct 5, 2021
abstractions/dotnet/Microsoft.Kiota.Abstractions.Tests/RequestInformationTests.cs
Outdated
Show resolved
Hide resolved
599b29a to
57e7ca8
Compare
This was referenced Oct 6, 2021
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
… typescript Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
- fixes url template params reference Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
- removes path parameters from raw constructor Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
- adds missing additional path parameters for raw url constructor in go - fixes casing conventions in go Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Contributor
andrueastman
left a comment
There was a problem hiding this comment.
Thanks for all this @baywet.
This looks good to me save for the comments left for now.
abstractions/dotnet/Microsoft.Kiota.Abstractions.Tests/RequestInformationTests.cs
Show resolved
Hide resolved
src/Kiota.Builder/Writers/TypeScript/TypeScriptConventionService.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
andrueastman
approved these changes
Oct 27, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Member
Author
|
Thanks for taking the time to fix that! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
fixes #628
generation diff
microsoft/kiota-samples#331