Skip to content

fixes serialization/deserialization of @ symbol#6754

Merged
baywet merged 7 commits intomicrosoft:mainfrom
The-Funk:bugfix_at_symbol_serialization
Sep 17, 2025
Merged

fixes serialization/deserialization of @ symbol#6754
baywet merged 7 commits intomicrosoft:mainfrom
The-Funk:bugfix_at_symbol_serialization

Conversation

@The-Funk
Copy link
Contributor

@The-Funk The-Funk commented Jul 12, 2025 •
edited by baywet
Loading

fixes #6688

@The-Funk The-Funk requested a review from a team as a code owner July 12, 2025 00:50
@The-Funk The-Funk mentioned this pull request Jul 12, 2025
Closed
baywet
baywet requested changes Aug 6, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Can you also add an entry to the changelog please (unreleased, changed)

@The-Funk
Copy link
Contributor Author

The-Funk commented Aug 8, 2025

@baywet updated changelog and got my branch up to date with main. 👍

baywet
baywet previously approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet enabled auto-merge August 11, 2025 13:35
@baywet
Copy link
Member

baywet commented Aug 11, 2025

@The-Funk we do have a test failure

Failed Kiota.Builder.Tests.Extensions.StringExtensionsTests.CleansUpSymbolNames(input: "@", expected: "at") [3 ms]
  Error Message:
   Assert.Equal() Failure: Strings differ
           ↓ (pos 0)
Expected: "at"
Actual:   "At"

would you mind please looking into it?

auto-merge was automatically disabled September 17, 2025 00:37

Head branch was pushed to by a user without write access

@The-Funk
Copy link
Contributor Author

The-Funk commented Sep 17, 2025

@baywet sorry for the delay, forgot all about this. The symbol cleanup uses PascalCase. I goofed and put "at" as the expectation but "At" should be the correct expectation. Fixed and updated branch.

baywet
baywet approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet enabled auto-merge September 17, 2025 12:04
@baywet baywet merged commit 7e40b6a into microsoft:main Sep 17, 2025
290 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow for overriding JSON serialization/deserialization related Code Generation

2 participants

@The-Funk @baywet